fly-apps / fly-apps/dockerfile-node

Prevent `dist` folders from static apps from being ignored

Open
#91 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
187
Forks
11
PR merge metrics
No merged PRs in 30d

Description

A friend had a dockerfile like this:

```
# syntax = docker/dockerfile:1

# Adjust NODE_VERSION as desired
ARG NODE_VERSION=18.7.0
FROM node:${NODE_VERSION}-slim as base

LABEL fly_launch_runtime="NodeJS"

# NodeJS app lives here
WORKDIR /app

# Set production environment
ENV NODE_ENV=production
ENV VITE_API_BASE_URL="https://japu-backoffice-dev.fly.dev/api/v1"
ARG YARN_VERSION=1.22.19
RUN npm install -g yarn@$YARN_VERSION --force
RUN npm install -g @quasar/cli

# Throw-away build stage to reduce size of final image
FROM base as build

# Install packages needed to build node modules
RUN apt-get update -qq && \
apt-get install -y python-is-python3 pkg-config build-essential

# Install node modules
COPY --link package.json yarn.lock ./

COPY . .

RUN yarn install --production=false

RUN npx quasar build

FROM pierrezemb/gostatic

# Copy built application
COPY --from=build /app/dist/spa /srv/http
```

And they tried to deploy and got an issue like:

```
=> ERROR [2/2] COPY ./dist/spa/ /srv/http/ 0.0s
------
[2/2] COPY ./dist/spa/ /srv/http/:
------
```

Because during launch they got asked to create a `.dockerignore` and accepted it. Probably it contained a line to ignore dist.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.