fly-apps / fly-apps/dockerfile-node

Handle SvelteKit adapters properly

Open
#60 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
187
Forks
11
PR merge metrics
No merged PRs in 30d

Description

- with SvelteKit using bun as the package manager and builder does not mean to use bun as the runner
- the runner language is determined by the adapter, not the runtime used to build
- I can use bun to build a nodejs output, and vice versa
- and also: with adapter-static, it should use the nginx thing it does for astro

Stories:
- Right now, if I launch a SvelteKit app that uses bun as its package manager but adapter-node as its runtime, it tries to run the node bundle with bun which won't work properly
- Right now, if I launch a SvelteKit app that uses adapter-static, it assumes it's node/bun and runs it with that
- Right now, the deno adapter and anything else probably is broken in a similar way

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.