fluttercommunity / fluttercommunity/font_awesome_flutter

Example Code-Definition in main.dart increases binary size when using custom FA

Open
#291 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
905
Forks
293
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Using Custom FA, its required to modify the code and import the lib as an override. However:
- I want to add the FA-Code to a repository, so changes can be made on the fly
- The "example" and "test" code is useless overhead when not needed
- example code is in the util\lib\main.dart in which it doesn't belong
- util is needed to regenerate with the configurator.sh or .bat

**To Reproduce**
- clone the repo INSIDE a repo into smth like third_party
- delete "example" folder
- get an error

**Expected behavior**
- no error
- slim FA version?

Version:
- FA 10.12

**Possible fix:**
- Modify util\lib\main.dart to pass variables so example is only run on demand
- Modify the util\lib\main.dart to duplicate into \example, so \example is its own project and the configurator needs to be run inside there
- Decouple example from base-code completely

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.