fluttercommunity / fluttercommunity/flutter_launcher_icons

[BUG] Non-Square Images Squished

Open
#214 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
2.1k
Forks
426
PR merge metrics
No merged PRs in 30d

Description

### :information_source: Info
Version: `0.8.1`

### :speech_balloon: Description

It looks like non-square images are squished, rather than padded, when generating iOS favicons.

This also affects `web` favicon generation in https://github.com/fluttercommunity/flutter_launcher_icons/pull/155.

These images are from the `example` project directory.

#### Original (iOS)

![image](https://user-images.githubusercontent.com/46334387/97780049-708b5080-1b3f-11eb-8676-572a3cc5fd5e.png)

#### Generated (iOS)

![image](https://user-images.githubusercontent.com/46334387/97780032-53ef1880-1b3f-11eb-8eb3-f40f91361979.png)

Is this expected behavior?

### :scroll: Pubspec.yaml
```yaml
name: example
description: A new Flutter project to quickly test flutter_launcher_icons.

version: 1.0.0+1

environment:
sdk: ">=2.7.0 <3.0.0"

dependencies:
flutter:
sdk: flutter
cupertino_icons: ^0.1.3
flutter_launcher_icons:
path: ../..

flutter_icons:
# image_path: "assets/images/icon-128x128.png"
image_path_android: "assets/images/icon-710x599-android.png"
image_path_ios: "assets/images/icon-710x599-ios.png"
image_path_web: "assets/images/icon-710x599-web.png"
android: true # can specify file name here e.g. "ic_launcher"
ios: true # can specify file name here e.g. "My-Launcher-Icon"
web: true # Can't specify file name here at present.
adaptive_icon_background: "assets/images/christmas-background.png" # only available for Android 8.0 devices and above
adaptive_icon_foreground: "assets/images/icon-foreground-432x432.png" # only available for Android 8.0 devices and above

dev_dependencies:
flutter_test:
sdk: flutter

flutter:
uses-material-design: true
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the example project's pubspec.yaml and its configured iOS and web image paths, then reproduce the generated assets using the non-square images described in the issue. Trace the image-generation entry points for iOS and web and compare their output with the originals. Done means non-square images preserve their aspect ratio by being padded rather than squished on both platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
mobile-dev, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.