flutter / flutter/flutter

[windows]: Clean up c/c++ interface for external textures

Open
#188,120 1 comment 0 reactions 0 assignees View on GitHub
c: new feature c: proposal c: tech-debt P3 team-windows triaged-windows
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

https://github.com/flutter/flutter/pull/187886 introduced an integration test for external textures on windows. It [was pointed](https://github.com/flutter/flutter/pull/187886/changes#r3429964945) out that it was unfortunate we had to drop down to the C API to implement everything.

We should have a C++ way to do this. Right now that's not possible because `FlutterEngine::GetRegistrarForPlugin` returns a C reference and the way the "texture registry" should be accessed is from the "plugin registrar".

Loic suggested adding a getter to the FlutterEngine directly, but this would deviate from the pattern on other platforms.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.