flutter / flutter/flutter

Remove `IMPELLER_OPENGLES_FLIP_DEPRECATED`

Open
#187,517 1 comment 0 reactions 0 assignees View on GitHub
e: impeller P2 team-engine triaged-engine
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

https://github.com/flutter/flutter/pull/187316 introduced a macro that helps people transition through the breaking change in https://github.com/flutter/flutter/pull/186556 where opengles fragment shaders no longer need to have special flipping logic. That macro was important for package developers so they could support `main` and `stable` version of flutter.

Once `IMPELLER_OPENGLES_FLIP_DEPRECATED` is on the stable channel (3.47.0?) it should be removed and its presence in the source code of a shader should be considered a compilation error.

cc @jason-simmons
cc @chunhtai
cc @justinmc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.