flutter / flutter/flutter

iOS VSyncClient's displayRefreshRate always return the maximum rate

Open
#185,759 1 comment 0 reactions 0 assignees View on GitHub
P2 platform-ios team-ios triaged-ios
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

Spot by Gemini during a code review: https://github.com/flutter/flutter/pull/185737#discussion_r3160372718

This was introduced by https://github.com/flutter/engine/pull/52104/changes#diff-ca0ba764dd3a3c6d10dfd05ea010d65973a4882b7f2549352367b97944a1fd8fL160-R151

Original code uses autorelease on DisplayLinkManager, which keeps it alive until next runloop. The new code could dealloc it eagerly since CADisplayLink doesn't retain the `target`.

### Expected results

NA

### Actual results

NA

### Code sample

NA

### Screenshots or Video

NA

### Logs

NA

### Flutter Doctor output

NA

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.