flutter / flutter/flutter

`ImageFilter.compose`: sampling outside of inner has backend differences

Open
#177,795 0 comments 0 reactions 0 assignees View on GitHub
e: impeller P2 team-engine triaged-engine
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

The differences have to do with taking away the extra 1 pixel padding from the RenderToSnapshot introduced in https://github.com/flutter/flutter/pull/177687. The differences show up in `ComposePaintRuntimeInner` and `ComposePaintRuntimeOuter` tests. The output I would expect is actually opengles in this case, the vulkan and metal outputs look wrong.

This removal of the padding was required to get pixel perfect fragment shading coordinates until we can potentially pass a transform into the ImageFilter.shader shader to represent the offset.

## ComposePaintRuntimeInner

### vulkan
Image

### opengles
Image

### metal
Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.