flutter / flutter/flutter

`ImageFilter.compose` golden tests are rendering at the wrong size on ci

Open
#177,612 0 comments 0 reactions 0 assignees View on GitHub
e: impeller P2 team-engine triaged-engine
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

The following tests are rendering at 2x the size they should be on CI. This is related to the dpi of the device running the tests.

affected tests:
- `ComposePaintRuntimeInner`
- `ComposePaintRuntimeOuter`

This was a problem in the past with all tests but it had been addressed. Since this affects both tests it seems specific to `ImageFilter.compose` not just `RuntimeEffect`.

introduced in https://github.com/flutter/flutter/pull/177510

## observed

(downloaded from skiagold)

Image

## expected

(generated locally on high dpi screen)

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.