flutter / flutter/flutter

[ios] guideline on iOS engine feature flags: Info.plist vs cmd flag

Open
#172,183 8 comments 0 reactions 0 assignees View on GitHub
P2 platform-ios team-ios triaged-ios
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

### Use case

There are currently 2 ways of setting the flag on iOS: via cmd line flags or via Info.plist. It's unclear to me which one to use, as I see pros and cons on both.

Also there's an inconsistent practice: on android, `systrace` is enabled via cmd flag([see](https://github.com/flutter/flutter/blob/d70c9528f8a18b7ca7fdf5fde723e4ad7fcf23c3/engine/src/flutter/shell/common/switches.h)), but on iOS it's enabled via Info.plist ([see](https://github.com/flutter/flutter/blob/d70c9528f8a18b7ca7fdf5fde723e4ad7fcf23c3/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm#L180))

### Proposal

Come up with a guideline for the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.