flutter / flutter/flutter

Revisit: Retrying in the merge group

Open
#169,377 3 comments 0 reactions 0 assignees View on GitHub
P2 team-infra triaged-infra
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

When monorepo was started, Mac bots were highly flakey in the merge group. We have automatic retries in these cases and it was very helpful to retry one or two bots.

Mac bots are way more stable now thanks to the teams efforts (🥳) but now the retries are blocking the merge group when there are _real_ failures (e.g. https://github.com/flutter/flutter/pull/169187)

We should probably:

1. Reduce the retry count in the merge group
2. Attempt to see if errors are real and fail fast
3. If we see multiple errors from different builders, fail fast.

Thoughts @matanlurey @zanderso ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.