flutter / flutter/flutter

[video_player] Remove public access to the caption file

Open
#168,823 0 comments 0 reactions 0 assignees View on GitHub
p: requires breaking change p: video_player P2 package team-ecosystem triaged-ecosystem
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

The existence of `Future? get closedCaptionFile` makes it impossible for the controller to transform the captions for its own use (e.g., sorting them for faster access) without extra complexity and memory; see https://github.com/flutter/packages/pull/8347 for context. There's no good reason I can see for the getter to be public; if the caller who set the caption file wants it for their own purposes, they can keep it directly instead of getting it from the player later.

Removing that public API at the next breaking change would let us do more optimizations to captions in the future without worrying about breaking API compat.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.