flutter / flutter/flutter

[packages] `make-deps-path-based` should include everything in a federated plugin

Open
#168,538 1 comment 0 reactions 0 assignees View on GitHub
c: contributor-productivity P2 package team-ecosystem triaged-ecosystem
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

Currently the tool logic for `make-deps-path-based` has logic that was intended to solve the issue of transitive dependencies by having `foo/example` get all the same overrides as `foo`. That's usually enough, but not always; in particular, cases where some unrelated plugin's example depends on `foo`, but the plugin itself doesn't, then the example gets only `foo` overridden but none of `foo`'s sub-dependencies, which causes CI failures. See https://github.com/flutter/packages/pull/9212 for an example.

The tool should have additional logic that anything depending on `foo*` gets *all* overrides in the `foo*` conceptual plugin group, to avoid missed cases.

(In general the changes to other packages aren't actually necessary at the stage where this causes problems, but having the tool generate partial changes that don't work just causes confusion.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.