flutter / flutter/flutter

WEB: support watch all of web_ui folder instead of only web_ui/lib

Open
#165,301 3 comments 0 reactions 0 assignees View on GitHub
c: new feature c: proposal engine P2 platform-web team-web triaged-web
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

### Use case

When run `felt build --watch` in this project I find some problems with this code https://github.com/flutter/flutter/blob/master/engine/src/flutter/lib/web_ui/dev/build.dart#L96, flutter only supports watch `web_ui/lib` folder change when developing locally. I hope there can support watching all of the web_ui folders like the `flutter_js` folder because I want to re-execute the js bundle build by esbuild when files in `flutter_js` changed

### Proposal

Change `final FilePath libPath = FilePath.fromWebUi('lib');` to ` final FilePath libPath = FilePath.fromWebUi('.');
`

If it can be approved, I can submit a pull request

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.