flutter / flutter/flutter

enable ASAN for impeller_unittests and impeller_golden_tests on macos ci

Open
#159,985 4 comments 0 reactions 0 assignees View on GitHub
e: impeller P2 team-engine triaged-engine
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

Spawned from https://github.com/flutter/engine/pull/57015

There is a `--asan` flag in GN. If you set it it will compile the binaries with the correct flags. The impeller targets will fail to compile though because `flatc` will fail to execute. Clang on macos links a runtime library ( `libclang_rt.asan_osx_dynamic.dylib` ) that isn't available to dyld without some sort of change. I'm not sure what mechanisms GN has to run otool to edit the linkage.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.