flutter / flutter/flutter

[impeller] implement golden image tests for linux

Open
#158,215 1 comment 0 reactions 0 assignees View on GitHub
e: impeller e: opengl P3 team-engine triaged-engine
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

Currently, all golden image tests are run on CI on mac bots. Swiftshader is used for Vulkan and ANGLE is used for OpenGLES.

In https://github.com/flutter/flutter/issues/157951 it was shown that the OpenGLES tests don't have antialiasing because ANGLE never implemented it for Metal.

The idea here is to get the golden tests running on linux CI so that:
1) We have anti-aliasing for our opengles golden tests
1) Running the golden tests locally on linux will make it easier to develop for linux developers

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.