flutter / flutter/flutter

Remove usages of ANDROID_SDK_ROOT in the engine

Open
#155,251 2 comments 0 reactions 0 assignees View on GitHub
c: proposal c: tech-debt engine P2 platform-android team-android triaged-android
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

https://github.com/search?q=repo%3Aflutter%2Fengine%20ANDROID_SDK_ROOT&type=code

https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/gradle-core/src/main/java/com/android/build/gradle/internal/SdkLocator.kt;l=197?q=Several%20environment%20variables%20and%2For%20system%20properties%20contain%20different%20paths%20to%20the%20SDK
https://cs.android.com/android-studio/platform/tools/base/+/24d480687a1d5f92d898dd49e23286cdf8b0e3fd

The reason for targeting the engine is that if both ANDROID_HOME and ANDROID_SDK_ROOT are set but have the same value then there is not an error. But the engine overrides the local android sdk when building so it causes build errors.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.