flutter / flutter/flutter

Android locale parsing may be able to use API 21+ methods now

Open
#144,321 0 comments 0 reactions 0 assignees View on GitHub
c: tech-debt P3 team-android triaged-android
Dominant language
Dart
Stars
179k
Forks
31.1k
PR merge metrics
PR metrics pending

Description

In https://github.com/flutter/engine/pull/51032/files#diff-a23bf0590068d5b3742c6748af913365408e0dc7bfe09c7c33063168ad71d8f2L204, I removed the `if (false` branch out of caution because that code appears to never have executed anywhere. We're currently parsing locale strings we probably don't have to.

@chingjun might remember why he put false there, but I suspect it was just a mistake that got missed in code review. It's probably safe to use the more concise code now.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.