flutter / flutter/flutter-intellij

Timer from FlutterWidgetPerf causing downstream test failure

Open
#3,648 1 comment 0 reactions 0 assignees View on GitHub
testing-infra
Dominant language
Java
Stars
2k
Forks
356
Avg merge
1d 11h
Merged PRs (30d)
27

Description

These tests pass when run alone:
`./gradlew test --tests LaunchCommandsTest`

As part of the test suite that gets run during a travis build we get this failure:
```
io.flutter.run.bazelTest.LaunchCommandsTest
✘ producesCorrectCommandLineForTestName (10.5s)
junit.framework.AssertionFailedError: Not disposed java.swing.Timer: Timer (listeners: [io.flutter.perf.FlutterWidgetPerf$$Lambda$5/1459788113@ed31ef4]) (delayed for 97ms); queue:TimerQueue (javax.swing.Timer@b53ad17)
```
This seems to be specific to travis; when run locally I cannot reproduce this failure.

Possibly related to #3610.

@jacob314

Contributor guide

Open the contributing guide

Research direction

Start by running ./gradlew test --tests LaunchCommandsTest and inspect the FlutterWidgetPerf timer lifecycle alongside LaunchCommandsTest. Reproduce the Travis-only failure if possible, then verify that the full test suite no longer reports an undisposed javax.swing.Timer.

Written by the indexing model from the issue text.

Assessment

Tech stack
flutter, java
Domain
desktop-dev, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.