flutter / flutter/devtools

TreeNode depth is likely sometimes incorrect

Open
#3,171 0 comments 0 reactions 0 assignees View on GitHub
audit P3
Dominant language
Dart
Stars
1.7k
Forks
404
Avg merge
6d 17h
Merged PRs (30d)
18

Description

TreeNode.depth assumes that TreeNodes are not modified after the first time depth is accessed but it likely code violates this assumption.
We should probably instead switch to a scheme where TreeNode depth values are invalidated when the tree structure bellow them changes although this needs to be done with care to avoid excessive computations of depth.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.