fluent / fluent/fluent-operator

bug: inconsistent behaviour for setting FluentBit labels and annotations

Open
#1,424 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
682
Forks
328
Avg merge
2d 23h
Merged PRs (30d)
13

Description

### Describe the issue

Setting FluentBit.Spec.Labels will set labels on both the DaemonSet and the pods.
Setting FluentBit.Spec.Annotations will set annotations only on the pods.

### To Reproduce

Create a FluentBit resource with both labels and annotations

### Expected behavior

Consistent behaviour for both of the options. Perhaps annotations should as well set the annotations on both the Daemonset and pods

### Your Environment

```markdown
- Fluent Operator version:
- Container Runtime:
- Operating system:
- Kernel version:
```

### How did you install fluent operator?

_No response_

### Additional context

Maybe append fb.Annotations and fb.Spec.Annotations and then set?
https://github.com/fluent/fluent-operator/blob/master/pkg/operator/daemonset.go#L36

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.