fluent / fluent/fluent-logger-python
emit() does not call handleError on exception.
- Dominant language
- Python
- Stars
- 457
- Forks
- 138
- PR merge metrics
- No merged PRs in 30d
Description
The [documentation](https://docs.python.org/3.8/library/logging.html#logging.Handler.handleError) for the `handleError` function of `logging.Handler` implies that exceptions should be caught by `emit` and handled by invoking `handleError`. This allows the environment to customer how logging errors are handled.
The fluent logger Handler does not do this: https://github.com/fluent/fluent-logger-python/blob/d1b81bafe442f9cd3059fa07da1fd8de4e92716c/fluent/handler.py#L237
The net result is that exceptions triggered when running the fluent logger (either in format or otherwise) are raised, as opposed to log, which is inconsistent with the rest of the logging Handlers.
The fluent logger should call handleError.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.