fluent / fluent/fluent-logger-php

Compatibility with php 8.4

Open
#71 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
218
Forks
58
PR merge metrics
No merged PRs in 30d

Description

In the file **src/Exception.php, line 32** should be updated:

`public function __construct(Entity $entity, $message = "", $code = 0, \Exception $previous = null)`

to

`public function __construct(Entity $entity, $message = "", $code = 0, ?\Exception $previous = null)`

because Implicitly nullable parameter types are now deprecated in PHP 8.4.

Additionally, in the file **src/FluentLogger.php, line 111** should be changed from:

`PackerInterface $packer = null)`

to

`?PackerInterface $packer = null)`

for the same reason: implicitly nullable parameter types are deprecated in PHP 8.4.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.