fluent / fluent/fluent-logger-node
`_status` not reset after FluentLoggerError.MissingTag
- Dominant language
- JavaScript
- Stars
- 258
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
On FluentLoggerError.MissingTag errors the reconnect handler (https://github.com/fluent/fluent-logger-node/blob/master/lib/sender.js#L453) does not set `_status` back to `established`, and does not re-emit the `connect` event.
Background: I've implemented a bounded event queue that queues if the fluent-logger is not connected, and attempts to flush when the logger reconnects. In cases of event data errors callers cannot be accurately notified of when the logger reconnects either through looking at `_status` or depending on the `connect` event.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at lib/sender.js around line 453, where the reconnect handler processes FluentLoggerError.MissingTag. Trace the reconnect behavior and verify that completion leaves the logger status and connect notification consistent with the issue description.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100