fluencelabs / fluencelabs/aquavm

Show instruction when logging join

Open
#237 0 comments 0 reactions 0 assignees View on GitHub
C-dx C-good-first-issue
Dominant language
Rust
Stars
154
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Right now, joins look like this

```
[2022-04-02T21:17:58.595125Z INFO aquamarine_0.21.3.wasm] waiting for an argument with idx '0' on stream with size '0'
[2022-04-02T21:17:58.595137Z INFO aquamarine_0.21.3.wasm] waiting for an argument with idx '0' on stream with size '0'
[2022-04-02T21:17:58.595140Z INFO aquamarine_0.21.3.wasm] waiting for an argument with idx '0' on stream with size '0'
```

For big AIR scripts, it's really hard / impossible to guess which line caused this. Printing instruction as in `last_error.instruction` would help a lot.

Contributor guide

Open the contributing guide

Research direction

Locate the code that logs join instructions and compare its available context with last_error.instruction. Update the join log output so it identifies the relevant instruction, then run the existing tests or reproduce the shown waiting-for-an-argument log to verify the instruction is included.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, wasm
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.