Checking the activity id is not null in the history manager

In both implementation of HistoryManager interface (DefaultHistoryManager and AsyncHistoryManager) from the ProcessEngineConfigurationImpl when you are recording to the history a new activity instance you are saying that: _"Historic activity instance could have been created (but only in cache, never persisted), for example when submitting form properties"_

Because I've my own implementation of an HistoryManager to sync with an external source (ActiveMQ) I think your validation of activityId is not null it could be wrong.


I think you wanted to validate the activity entity id, the primary key if persisted, and not whether this activity has an identifier or not.
So instead of activityInstance.getActivityId() != null maybe you want to check if activityInstance.getId() != null