flowable / flowable/flowable-engine

IdmEngineConfiguration does not execute any EngineConfigurators

Open
#2,464 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
9.5k
Forks
2.9k
Avg merge
7h 8m
Merged PRs (30d)
2

Description

**Describe the bug**
The IdmEngineConfiguration can have EngineConfigurators added to it (inherited from the AbstractEngineConfiguration) but these are not executed when the IdmEngineConfiguration is initialised.

For example if we create a SpringIdmEngineConfiguration bean:

@Bean
public SpringIdmEngineConfiguration idmEngineConfiguration(
EngineConfigurator engineConfigurator) {

SpringIdmEngineConfiguration idmEngineConfiguration = new SpringIdmEngineConfiguration();
idmEngineConfiguration.addConfigurator(engineConfigurator);

return idmEngineConfiguration;
}

Then the inserted `engineConfigurator` will not have its `beforeInit(...)` or `configure(...)` called, and is effectively ignored.

We can see that in `IdmEngineConfiguration` the `init()` method there are no calls made to any of `initConfigurators()`, `configuratorsBeforeInit()` or `configuratorsAfterInit()` which the other engine configurations use in their `init()` methods.

https://github.com/flowable/flowable-engine/blob/a5fe7d59662b9f7f6b74c9a5756ed1d71913570d/modules/flowable-idm-engine/src/main/java/org/flowable/idm/engine/IdmEngineConfiguration.java#L170

**Expected behavior**
In this case I would expect the `beforeInit(...)` and `configure(...)` methods in the `engineConfigurator` to be called when initialising the IdmEngineConfiguration in exactly the same way as the other engines (Process, CMMN, DMN, etc).
This would make the setup of the IdmEngine to follow the same behaviour of other engines and to be consistent.

**Code**
See above.

**Additional context**
Flowable-6.5.0 and Spring 5.2.2.RELEASE without Spring-Boot

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.