flore2003 / flore2003/nativescript-markdown-view

PodFile SWIFT_SWIFT3_OBJC_INFERENCE to On

Open
#13 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
19
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Hi,

I've recently installed your great markdown lib into my Nativescript angular app. Thanks for that !
But it seems your PodFile is changing the build configuration of Xcode.

`post_install do |installer|`
` installer.pods_project.targets.each do |target|`
` target.build_configurations.each do |config|`
` config.build_settings['SWIFT_SWIFT3_OBJC_INFERENCE'] = 'On'`
` end`
` end`
`end`

`pod 'TSMarkdownParser'`

This was failing the iOS build process for other libs !

Example of error it created with **nativescript-toasty** :

`error: method 'makeToastActivity' with Objective-C selector 'makeToastActivity:' conflicts with previous declaration with the same Objective-C selector
@objc func makeToastActivity(_ point: CGPoint) {
^
.../platforms/ios/Pods/Toast-Swift/Toast/Toast.swift:279:9: note: 'makeToastActivity' previously declared here
func makeToastActivity(_ position: ToastPosition) {
^
note: Using new build systemnote: Planning buildnote: Constructing build descriptionwarning: **The use of Swift 3 @objc inference in Swift 4 mode is deprecated**. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and then disable inference by changing the **"Swift 3 @objc Inference" build setting to "Default"** for the "Toast-Swift" target. (in target 'Toast-Swift' from project 'Pods')warning: The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and then disable inference by changing the "Swift 3 @objc Inference" build setting to "Default" for the "Toast-Swift" target. (in target 'Toast-Swift' from project 'Pods')
** BUILD FAILED **`

**---> So I needed to change this line to :**

`config.build_settings['SWIFT_SWIFT3_OBJC_INFERENCE'] = 'Default'`

to get the build pass and working again.

Can you confirm that changing this will not make your lib not working as expected ?

If so, can you update your repo ?

Thanks for help and thank you for this plugin !
Lo.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.