flaviusmatis / flaviusmatis/simplePagination.js

selecting page by clicking ellipses doe not update location.hash

Open
#155 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
777
Forks
397
PR merge metrics
No merged PRs in 30d

Description

If a page is selected by clicking the ellipse and using the up and down arrows to change the number, then clicking enter the value for location.hash is not changed.

This is fixed in this code snippet starting at line 363 in jquery.simplePagination.js:

` if ((val>0)&&(val<=o.pages)) {
methods._selectPage.call(self, val - 1);
location.hash = "#page-" + val;
}
`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in jquery.simplePagination.js around line 363 and reproduce the ellipse-selection flow with the up and down arrows, then Enter. Compare the resulting location.hash with the expected #page- value shown in the issue. Done means selecting a page this way updates location.hash consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.