flathub / flathub/io.github.shiftey.Desktop

An error when trying to sign a commit: no pinentry

Open
#22 26 comments 4 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
33
Forks
9
PR merge metrics
No merged PRs in 30d

Description

**Issue**
Not possible to sign commits for now. When I try to make a commit with `gpgSign = true` in my config, I see the following error:
![image](https://user-images.githubusercontent.com/46246344/142257315-38cccaad-f290-431f-b8d0-c7ac8c2ff17b.png)

But it works if I first make a commit outside flatpak and then do another commit in the Github Desktop application.

**Possible cause**
If I try to launch this package in cli: `flatpak run --command=sh io.github.shiftey.Desktop`, and type `echo test | gpg --clear-sign`, I get this:
```
gpg: WARNING: server 'gpg-agent' is older than us (2.2.20 < 2.2.31)
gpg: Note: Outdated servers may lack important security fixes.
gpg: Note: Use the command "gpgconf --kill all" to restart them.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

test
gpg: signing failed: pinentry error
gpg: [stdin]: clear-sign failed: pinentry error
```

As I understand, to support gpg signing this flatpak package should include its own version of `pinentry`, at least for now.

You can find some discussion regarding this on other flatpak repos, e. g. https://github.com/flathub/org.gnome.Evolution/issues/12

## Additional info
Host OS: Fedora 35

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.