flathub / flathub/com.google.Chrome

PWAs create invalid .desktop files

Open
#347 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
67
Forks
39
Avg merge
6h 48m
Merged PRs (30d)
7

Description

When creating a PWA, it creates an invalid desktop file:

```
#!/usr/bin/env xdg-open
[Desktop Entry]
Version=1.0
Terminal=false
Type=Application
Name=Microsoft Teams
Exec=flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'
Icon=chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default
NoDisplay=true
StartupWMClass=crx_cifhbcnohmdccbgoicgdjpfamggdegmo
X-Flatpak-Part-Of=com.google.Chrome
TryExec=/var/lib/flatpak/exports/bin/com.google.Chrome
```

When running this validation tool, it complains about the following:

```
$ desktop-file-validate com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
```

This is fixed when changing the Exec to:
```
Exec=flatpak run --command=/app/bin/chrome com.google.Chrome --profile-directory=Default --app-id=cifhbcnohmdccbgoicgdjpfamggdegmo
```

Both Exec's work, but only the latter Exec is valid according to the [desktop-file-validate](https://www.freedesktop.org/wiki/Software/desktop-file-utils/) tool.

I'm using version 131.0.6778.204-1 of the Chrome Flatpak on Fedora Silverblue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.