flashbots / flashbots/rpc-endpoint

README seems innaccurate - doesTxNeedFrontrunningProtection doesn't check gas > 42,000

Open
#138 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
213
Forks
65
PR merge metrics
No merged PRs in 30d

Description

The README, in this [section](https://github.com/flashbots/rpc-endpoint?tab=readme-ov-file#transaction-frontrunning-protection-evaluation-rules), says

> - Does the transaction use more than 42,000 gas? If it doesn't then the Flashbots Relay will reject it, and we're not aware of use cases that use such low gas that need frontrunning protection. Thus, we send low gas transactions to the mempool.

However, [doesTxNeedFrontrunningProtection](https://github.com/flashbots/rpc-endpoint/blob/e01c72732ff88b58cca8ad1de6468e7ccf3577aa/server/request_sendrawtx.go#L176) only logs the gas usage but doesn't check that the gasLimit is > 42,000. I also ctrl-f'ed the repo for `42000`, `42,000`, 42_000` and couldn't find anything.

Is the readme bullet point still accurate?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.