flashbots / flashbots/mev-boost
Info msg "no bid received" misleading for bids below min-bid
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 292
- PR merge metrics
- No merged PRs in 30d
Description
When calling the relays:
// Call the relays
var mu sync.Mutex
var wg sync.WaitGroup
for _, relay := range m.relays
the answers of the relays get checked for various circumstances. One of which is the check against the min-bid:
// Skip if value (fee) is lower than the minimum bid
if responsePayload.Value().Cmp(m.relayMinBid.BigInt()) == -1 {
log.Debug("ignoring bid below min-bid value")
return}
If the bid is below the min bid it does not get added to the Hash of Bids.
If all set relays are below min bid the Has is empty and the result/Info given bei the logs is "no bid received" which is misleading and makes room for questions about the setup.
if result.blockHash == "" {
log.Info("no bid received")
w.WriteHeader(http.StatusNoContent)
return}
Would be better to have an additional/different msg/info if the relays "all bids below min-bid - creating own block"
Contributor guide
Assessment
This issue has not been assessed yet.