flashbots / flashbots/attested-tls

PCCS crate will panic if used without a tokio runtime

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
5
Forks
3
Avg merge
4d 1h
Merged PRs (30d)
8

Description

The PCCS crate uses `tokio::spawn` which will panic if called outside of a tokio runtime.

We should either:
- Reimlpement dcap_qvl's `get_collateral_for_fmspc` to use a synchronous http client for fetching if `tokio::runtime::Handle::try_current()` fails.
- Or clearly document that the PCCS crate will not work without a tokio runtime.

See discussion: https://github.com/flashbots/attested-tls/pull/3#discussion_r2974715361

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.