flashbots / flashbots/attested-tls

feat: use builder pattern in `attestation` crate to tune attestation logic

Open
#19 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
5
Forks
3
Avg merge
4d 1h
Merged PRs (30d)
8

Description

in `attestation` crate we have two methods `verify_dcap_attestation` (with basic list of args) and `verify_dcap_attestation_with_given_timestamp` (with extended list) that could be collapsed into just one if we use builder pattern.

for example, we could have something like:

```rust
#[derive(Default)]
struct Verifier {
pccs_url: Option,
now: Option,
collateral: Option,
override_azure_outdated_tcb: bool,
}
```

with builder methods like `.with_pccs_url(pccs_url)`, and a method `.verify(input, expected_result)`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.