flarum / flarum/issue-archive

Catch Email Errors on signup

Open
#57 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-discussion type/cleanup
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Feature Request

When signing up without having a correct email configuration at the moment, the modal fails and shows "oops, something went wrong" but the user is still created. This leads to a poor UX.
Instead, the error should be caught, and the email logged - perhaps if we set the default mail driver to "log" on flarum creation also?

Describe the solution you'd like
A detailed description of your proposed solution. Include:

  • Default Flarum installations should set mail driver to log.
  • Wrap the signup in a try/catch and catch the failed email as a log.
  • User should be suspended pending activation, as the user has still been created - just no email sent.

Justify why this feature belongs in Flarum's core, rather than in a third-party extension
Core feature - Signup.

REQUIRES DISCUSSION

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the signup flow and the mail configuration entry point; the issue names no files or tests. Resolve whether the default mail driver, failed-email logging, and suspended-pending-activation behavior belong in the proposed scope, then verify that signup no longer shows an error after creating a user without sending mail.

Written by the indexing model from the issue text.

Assessment

Domain
authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.