flarum / flarum/issue-archive

Search source filters users on username

Open
#313 2 comments 1 reaction 0 assignees View on GitHub
type/cleanup
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

It's very difficult to extend the search for users, because the SearchUsersSource component filters the users store based on the username. I was doing some work overriding the whole view of that component, that would however disable any extending by other extensions (eg masquerade wants to allow searching on custom fields, whereas user directory wants to add the link to the user directory).

A revamp of this component is required, I was considering an ItemList for results in addition to storing results in the store alone. But that's not a complete solution.

Contributor guide

Open the contributing guide

Research direction

Start with the SearchUsersSource component and trace how it reads the users store and how extensions such as masquerade and user directory interact with it. Define the intended extensibility boundaries and a complete result-handling approach before changing the component; done means those extensions can add their behavior without overriding the whole view.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, search
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.