flarum / flarum/framework

[1.x] Backport #3920

Open
#4,891 0 comments 0 reactions 0 assignees View on GitHub
type/bug
Dominant language
PHP
Stars
6.7k
Forks
883
Avg merge
15h 16m
Merged PRs (30d)
73

Description

### Current Behavior

See the original issue at https://github.com/flarum/issue-archive/issues/39 and fix for the 2.x branch at https://github.com/flarum/framework/pull/3920. IMO it's a major enough issue that it warrants a back port. However, especially if backwards compatibility is of concern, I understand if we don't want to port this.

### Steps to Reproduce

.

### Expected Behavior

.

### Screenshots

_No response_

### Environment

- Flarum version: x.y.z
- Website URL: http://example.com
- Webserver: [e.g. apache, nginx]
- Hosting environment: [e.g. shared, vps]
- PHP version: x.y.z
- Browser: [e.g. chrome 67, safari 11]

### Output of `php flarum info`

```
Output of "php flarum info", run this in terminal in your Flarum directory.
```

### Possible Solution

_No response_

### Additional Context

Can this change be backported withou backwards compatibility concerns?

Contributor guide

Open the contributing guide

Research direction

Start by reading the original issue at flarum/issue-archive#39 and the 2.x fix in framework pull request #3920. Compare that change with the 1.x branch and check its backward-compatibility implications. Done means determining whether the change can be safely backported and, if so, verifying the relevant 1.x behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.