flarum / flarum/framework

Likes sends notifications for post types that have no text body

Open
#4,108 0 comments 0 reactions 0 assignees View on GitHub
type/bug type/feature
Dominant language
PHP
Stars
6.7k
Forks
883
Avg merge
15h 16m
Merged PRs (30d)
73

Description

### Current Behavior

We received two pull requests (#4075 and #4095) where the Likes extension is modified to only send notifications for the Post type Comment. The problem seems to be that the notification cannot render the `content` as text for any other Post type.

Although the proposed solutions are valid solutions to this problem, we need something that is future proof and extensible.

### Possible Solution

What we need to do is extend the Post type class with a property that allows us to signify whether a Post type is allowed to `notify`.

The benefit is that implementations of Post type can easily be adapted to this new feature, without sacrificing any flexibility.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.