flame-engine / flame-engine/flame

ShapeHitbox.allowSiblingCollision could be moved into broadphase

Open
#2,595 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Dart
Stars
10.8k
Forks
1k
Avg merge
1d 20h
Merged PRs (30d)
21

Description

# What could be improved
Ideally, we cah check `allowSiblingCollision` at broadphase, before creating unnecesary `CollisionProspect` for siblings pairs. And skip several iterations over "potentials" list later.

# Why should this be improved
A little bit better performance.

# Any risks?
Every broadphase implementation should implement it's unique "siblings check". An interface could be added for that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.