fkling / fkling/astexplorer

Highlighting nodes doesn't work well for recast

Open
#445 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
6.5k
Forks
772
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
With the new highlighting logic, tokens within the location information are highlighted, which is not useful.

**To Reproduce**
Steps to reproduce the behavior:
1. Select recast as parser
2. Select esprima in its settings
3. Click anywhere in the code

**Expected behavior**
The corresponding AST node should be highlighted.

**Screenshots**
![Screenshot_2019-09-25_10-10-10](https://user-images.githubusercontent.com/179026/65581920-a513fc80-df7c-11e9-8bd7-2ad8739ca55d.png)
---

For highlighting purposes we probably should not descent into location information nodes.

This can be easily mitigated for now by selecting "Hide location information".

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.