fkhadra / fkhadra/react-toastify

closeOnClick still requires disabling

Open
#1,128 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
13.4k
Forks
741
PR merge metrics
No merged PRs in 30d

Description

We just updated to v10.0.5 from v9.x. The docs for v10 say `closeOnClick` now defaults to false, however in our tests that's not true.

With it set to false like the following code, toasts do not close when clicked (unless they click a dismiss button). Removing this prop enables the close-on-click functionality, I can now close the toasts when clicking anywhere on them.

```tsx

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.