fkhadra / fkhadra/react-on-screen
Component could prevent updates propagating through render prop
Open
- Dominant language
- JavaScript
- Stars
- 402
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
Frustratingly, after reading this blog post https://cdb.reacttraining.com/react-inline-functions-and-performance-bdff784f5578 it looks like the `shouldComponentUpdate` optimisation I included in #21 will prevent prop changes propagating through to components within the render prop :(
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.