fkhadra / fkhadra/react-contexify

Disabling a menu item prevents menu from closing

Open
#264 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.2k
Forks
132
PR merge metrics
No merged PRs in 30d

Description

**Do you want to request a *feature* or report a *bug*?**

Bug

**What is the current behavior?**

If clicking a menu item disables an item in the menu, the menu remains on the screen.

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:**

https://codesandbox.io/p/sandbox/crimson-thunder-crwcng

I can't figure out the error I'm seeing in the preview, but when I run the code locally it runs fine and demonstrates the problem when you decrement the counter to 0.

**What is the expected behavior?**

The menu should disappear as usual.

**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**

Edge Version 123.0.2420.81 (Official build) (64-bit)
Windows 11

"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-scripts": "^5.0.0",
"react-contexify": "6.0.0"

I don't know of a React version where it works.

Contributor guide

Open the contributing guide

Research direction

Start with the linked CodeSandbox and reproduce the issue by decrementing the counter to 0, then inspect the menu behavior in react-contexify 6.0.0. Done means clicking the item disables it while the menu still disappears as usual; verify the behavior in the reported Edge and Windows 11 environment.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.