fkhadra / fkhadra/react-contexify

Submenu hidden/disable not identical to Item

Open
#201 0 comments 0 reactions 0 assignees View on GitHub
candidate next release
Dominant language
TypeScript
Stars
1.2k
Forks
132
PR merge metrics
No merged PRs in 30d

Description

**Do you want to request a *feature* or report a *bug*?**
Bug either Docs or Submenu component.

**What is the current behavior?**
handlerParams in Submenu doesn't include data property, which isn't even defined for Submenu.

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:**
https://fkhadra.github.io/react-contexify/disable-hide-submenu says it's the same as Item, but it's not.
https://github.com/fkhadra/react-contexify/blob/42e7d2061306e9d9744c1dddc5cae748a9772fce/src/components/Submenu.tsx#L66-L69

**What is the expected behavior?**
That I can provide data property to Submenu and it will be provided with the handlerParams to the BooleanPredicate just like Item.

OR

Clear documentation that this isn't supported for Submeny

**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
Version 5 of react-contexify

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.