fixthestatusquo / fixthestatusquo/proca-queue

Unhandled system.campaign_updated events go straignt to the fail queue

Open
#132 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

When sending events to the "delivery" queue (use case: double opt-in sync with CleverReach), not only the expected supporter.email_status events (eventType: "supporter.email_status") are added to the delivery queue.

There are also "[campaign updated](https://github.com/fixthestatusquo/proca-server/blob/main/proca/guides/Processing.md#campaign-updated)" events ( `eventType: "system.campaign_updated"`) which are not handled with proca-queue.

It leads to constant [nacking ](https://github.com/fixthestatusquo/proca-queue/blob/0da17085e233c0b88fd6d9ba27e957011ad1959f/src/queue.ts#L141) and requeuing of such messages. Nacked messages pile up in a fail queue, and it is almost impossible to distinguish them from messages backed for other reasons.

We need to upgrade proca-queue to handle these messages.

To reproduce run `npm run start -- -e hateaid`, change any hateaid-test campaigns, and check the 981 fail queue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.