fivetran / fivetran/jsonforms-antd-renderers

Write explanation for strictmode test rendering + useEffect with no deps

Open
#64 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
23
Forks
4
PR merge metrics
No merged PRs in 30d

Description

The bug and why this fixes it is hard to get my head around. I think we need some kind of write-up or comment as to the "why" on how this works. My biggest question is around the lack of deps array with that useEffect.

_Originally posted by @tyler-hoffman in https://github.com/great-expectations/jsonforms-antd-renderers/pull/63#pullrequestreview-1983181289_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.