fivetran / fivetran/dbt_salesforce

[Feature] dbt Compile Error due to Comments

Open
#64 3 comments 0 reactions 0 assignees View on GitHub
type:enhancement update_type:feature
Dominant language
No language data
Stars
53
Forks
38
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this? No

- [x] I have searched the existing issues

### Describe the issue

Hi, im getting dbt compile errors for dbt Salesforce Transformation. I think the culprit are the comments in SQL style and not in Jinja. Sample: https://github.com/fivetran/dbt_salesforce/blob/cb4329e50e2b60ce67b597261c3fb7aefa62d72f/models/salesforce/intermediate/int_salesforce__date_spine.sql#L2

Can i request for a code change for all files that uses "--" for commenting to be replaced by Jinja style commenting "{# #}"

### Relevant error log or model output

```shell
Runtime Error
Database Error in model int_salesforce__date_spine (models/salesforce/intermediate/int_salesforce__date_spine.sql)
TrinoUserError(type=USER_ERROR, name=SYNTAX_ERROR, message="line 4:22: mismatched input ':'. Expecting: '%', '(', '*', '+', '-', '.', '/', 'AND', 'AS', 'AT', 'OR', '[', '||', ", query_id=20250616_174557_72349_4cbij)
```

### Expected behavior

dbt compile runs successfully

### Possible solution

Image

Image

Image

### dbt Project configurations

`vars:
# for Fivetran Transformation
salesforce_source:
salesforce_database: jobber_lakehouse
salesforce_schema: landing_salesforce
salesforce_history_database: jobber_lakehouse
salesforce_history_schema: landing_salesforce

account: "{{ source('salesforce', 'account') }}"
opportunity: "{{ source('salesforce', 'opportunity') }}"
user: "{{ source('salesforce', 'user') }}"
user_role: "{{ source('salesforce', 'user_role') }}"
contact: "{{ source('salesforce', 'contact') }}"
lead: "{{ source('salesforce', 'lead') }}"
task: "{{ source('salesforce', 'task') }}"
event: "{{ source('salesforce', 'event') }}"
opportunity_line_item: "{{ source('salesforce', 'opportunity_line_item') }}"

opportunity_history: "{{ source('salesforce', 'opportunity_history') }}"

salesforce__user_role_enabled: true
salesforce__lead_enabled: true
salesforce__event_enabled: true
salesforce__task_enabled: true
salesforce__opportunity_line_item_enabled: true
salesforce__order_enabled: false
salesforce__product_2_enabled: true

salesforce__account_history_enabled: false
salesforce__contact_history_enabled: false
salesforce__opportunity_history_enabled: true`

### Package versions

` - package: fivetran/salesforce
version: [">=1.2.0", "<1.3.0"]
- package: fivetran/fivetran_utils
version: [">=0.4.0", "<0.5.0"]
- package: dbt-labs/spark_utils
version: [">=0.3.0", "<0.4.0"]`

### What database are you using dbt with?

other (mention it in "Additional Context")

### How are you running this dbt package?

dbt Core™

### dbt Version

1.9.6

### Additional Context

Implementing this in a Lakehouse with Trino as the compute, s3 as storage

### Are you willing to open a PR to help address this issue?

- [ ] Yes.
- [x] Yes, but I will need assistance.
- [ ] No.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with models/salesforce/intermediate/int_salesforce__date_spine.sql at the linked comment, then inspect the other SQL models for the same commenting pattern. Run dbt compile using the reported Trino setup and confirm it succeeds after the comment changes are applied consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
data-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.