fivetran / fivetran/dbt_reddit_ads

[Feature] Update to use `fivetran_utils.extract_url_parameter` instead of `dbt_utils.get_url_parameter`

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
issue:copycat priority:p4 status:accepted type:enhancement update_type:models
Dominant language
No language data
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

*Copied from [fivetran/dbt_facebook_ads #37](https://github.com/fivetran/dbt_facebook_ads/issues/37).*

### Is there an existing feature request for this?

- [X] I have searched the existing issues

### Describe the Feature

An issue with `dbt_utils.get_url_parameter` was discovered in https://github.com/fivetran/dbt_linkedin_source/issues/55 for Databricks SQL. Macro `fivetran_utils.extract_url_parameter` was added to solve this issue for Databricks targets (see https://github.com/fivetran/dbt_fivetran_utils/pull/130 more info).

For this package, references to `dbt_utils.get_url_parameter` need to be updated to `fivetran_utils.extract_url_parameter`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the dbt_reddit_ads repository for references to dbt_utils.get_url_parameter and review each affected model or macro. Replace those references with fivetran_utils.extract_url_parameter, then verify that all references have been updated and the package's checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
data-engineering
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.