fivetran / fivetran/dbt_linkedin_pages
[Feature] Add not null tests
Open
Nobody has claimed this yet.
issue:copycat
type:enhancement
- Dominant language
- No language data
- Stars
- 3
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Copied from fivetran/dbt_stripe #97.
Is there an existing feature request for this?
- I have searched the existing issues
Describe the Feature
We should add not_null tests where appropriate. For example, we have a combination of columns test here, but we don't have a not_null test for balance_transaction_id.
How would you implement this feature?
Add not_null tests where they are missing.
Describe alternatives you've considered
No response
Are you interested in contributing this feature?
- Yes.
- Yes, but I will need assistance.
- No.
Anything else?
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the model YAML definitions and the existing combination-of-columns test shown in models/stripe.yml. Identify columns lacking appropriate not_null tests, add those tests, and verify the dbt package's model tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- yaml
- Domain
- data-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100